Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CBRD-25241] Add SQL syntax to change the owner of the serial #5038

Merged
merged 33 commits into from
May 8, 2024
Merged

[CBRD-25241] Add SQL syntax to change the owner of the serial #5038

merged 33 commits into from
May 8, 2024

Conversation

jongmin-won
Copy link
Contributor

http://jira.cubrid.org/browse/CBRD-25241

To change the owner of the current serial, the 'CALLchange_serial_owner()' method must be performed, and the results of this method are successfully synchronized in the HA environment.

However, for user convenience, it is necessary to add an SQL statement to change the owner of serial.

Jongmin Won added 6 commits March 5, 2024 17:18
ADD Syntax ALTER SERIAL .. OWNER TO ..
a099d37
1) style: Change au_change_serial_owner_method() to au_change_serial_…
92e8f4e 
…owner(), 2) Fix feat: Modified to decache only when executing the opt_serial_option_list option when executing the alter serial syntax
Modified to the contents confirmed on 03/12 day, 1) style : change au…
9715b94 
…_change_serial_owner() to au_change_serial_owner_method(), 2) style : changed permission-related error messages when changing serial owner
style : Modify the authenticate.c file line
83dcf82
style : Correct error in authenticate.c file
3f38dfb
Merge remote-tracking branch 'upstream/develop' into CBRD-25241
2639f0a
@jongmin-won jongmin-won self-assigned this Mar 15, 2024
@jongmin-won jongmin-won marked this pull request as ready for review March 18, 2024 01:41
@jongmin-won jongmin-won requested a review from beyondykk9 as a code owner March 18, 2024 01:41
@beyondykk9 beyondykk9 requested review from ctshim, hgryoo and hyunikn March 21, 2024 23:42
@jongmin-won jongmin-won force-pushed the CBRD-25241 branch 2 times, most recently from ca147bd to 8452dd9 Compare April 9, 2024 09:43
@hyunikn hyunikn self-requested a review April 11, 2024 06:54
@ctshim ctshim self-requested a review April 11, 2024 08:03
hyunikn
hyunikn reviewed Apr 11, 2024
View reviewed changes
msg/de_DE.utf8/cubrid.msg Outdated Show resolved Hide resolved
src/parser/csql_grammar.y Outdated Show resolved Hide resolved
@jongmin-won jongmin-won force-pushed the CBRD-25241 branch 2 times, most recently from 3098228 to 0086df5 Compare April 15, 2024 04:57
@ctshim ctshim self-requested a review April 23, 2024 00:53
@hgryoo hgryoo self-requested a review April 23, 2024 05:56
@hgryoo
Copy link
Member

hgryoo commented Apr 23, 2024

  1. In the following example, a user can not know change_serial_owner is used internally at the ALTER SERIAL statement. IMO, proper error message should be shown.
CREATE USER test_user1; 
CREATE SERIAL cubrid_seq;

CALL login ('public', '') ON CLASS db_user;

ALTER SERIAL dba.cubrid_seq OWNER TO test_user1;

/* 
ERROR: before ' ; '
DBA, and members of DBA group can perform change_serial_owner.
*/
  1. About the seiral decach logic that you described in the comment of JIRA issue, It seems not related to the adding SQL syntax. Please add a new issue that changing serial decache behavior. If adding SQL syntax and changing the behavior should be resolved together, please change the title of the JIRA issue and the PR.

hgryoo
hgryoo reviewed Apr 26, 2024
View reviewed changes
src/parser/parse_tree.h Outdated Show resolved Hide resolved
@jongmin-won jongmin-won requested review from hgryoo and hyunikn April 28, 2024 15:31
@jongmin-won jongmin-won merged commit 81709c4 into CUBRID:develop May 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctshim ctshim ctshim approved these changes

@hyunikn hyunikn hyunikn approved these changes

@beyondykk9 beyondykk9 beyondykk9 approved these changes

@hgryoo hgryoo hgryoo approved these changes

Assignees

@jongmin-won jongmin-won

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jongmin-won @hgryoo @beyondykk9 @hyunikn @ctshim